Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaSessionConnector.PlaybackPreparer parameter is not properly annotated with @Nullable #7234

Closed
eprendre opened this issue Apr 14, 2020 · 1 comment
Closed

MediaSessionConnector.PlaybackPreparer parameter is not properly annotated with @Nullable #7234

eprendre opened this issue Apr 14, 2020 · 1 comment
Assignees
@marcbaechinger
Labels
bug

Comments

@eprendre
Copy link

MediaSessionConnector.PlaybackPreparer.onPrepareFromUri's parameter extras is not annotated with @nullable.
This forces kotlin to override nonnull parameter.
As tested, this will crash on api level 19 and 21: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter extras
@marcbaechinger marcbaechinger self-assigned this Apr 14, 2020
icbaker pushed a commit that referenced this issue Apr 27, 2020
@marcbaechinger @icbaker
Add missing nullable annotations
1699ab0 
The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback
from the framework which can be null. This needs to be properly annotated
with @nullable.

Issue: #7234
PiperOrigin-RevId: 307822764
@marcbaechinger
Copy link
Contributor

The missing annotations have been added (see commit above). Many thanks for reporting.
I'm going to close this issue. Please re-open if I missed something.

ojw28 pushed a commit that referenced this issue May 28, 2020
@marcbaechinger @ojw28
Add missing nullable annotations
13ec4f6 
The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback
from the framework which can be null. This needs to be properly annotated
with @nullable.

Issue: #7234
PiperOrigin-RevId: 307822764
andrewlewis pushed a commit that referenced this issue Jun 1, 2020
@marcbaechinger @andrewlewis
Add missing nullable annotations
6805907 
The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback
from the framework which can be null. This needs to be properly annotated
with @nullable.

Issue: #7234
PiperOrigin-RevId: 307822764
@google google locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marcbaechinger marcbaechinger

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcbaechinger @eprendre