BasePlayer::setMediaItems resetPosition is not used

[loki666]

ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/BasePlayer.java

Line 48 in 8a0d52b

public void setMediaItems(List<MediaItem> mediaItems, boolean resetPosition) {

[krocard]

@marcbaechinger is this on purpose? simpleExoPlayer overrides the method but only calls ExoPlayerImpl which use the BasePlayer implementation ignoring the parameter. So resetPosition seems to always be ignored for both setMediaItem methods with a resetPosition parameter when calling on SimpleExoPlayer or ExoPlayerImpl.

[marcbaechinger]

Yes, that doesn't look right. Thanks for reporting. I look into this.

Edit: As a workaround you can do

setMediaItems(items, 0, C.TIME_UNSET);

instead of

setMediaItems(items, /* resetPosition= */ true);

[loki666]

Yes, that doesn't look right. Thanks for reporting. I look into this.

Edit: As a workaround you can do

setMediaItems(items, 0, C.TIME_UNSET);

instead of

setMediaItems(items, /* resetPosition= */ true);

thanks, I'm calling seekTo after setMediaItems as a workaround now

[marcbaechinger]

Cool! Fix is on it's way, btw.

Just to be a bit more precise to my comment above. A general solution would need something like this:

Timeline timeline = player.getCurrentTimeline();
int windowIndex = timeline.isEmpty()
    ? 0 
    : timeline.getFirstWindowIndex(player.getShuffleModeEnabled());
player.setMediaItems(items, windowIndex, C.TIME_UNSET);