Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding same ad url for multiple MediaItems does not work #9106

Closed
Debayudh opened this issue Jun 24, 2021 · 2 comments
Closed

Adding same ad url for multiple MediaItems does not work #9106

Debayudh opened this issue Jun 24, 2021 · 2 comments
Assignees
Labels

Comments

@Debayudh
Copy link

While passing same List of MediaItems into player, if the same ad url is used for multiple Media Items, the ad plays only once and does not play for subsequent MediaItems.

@andrewlewis
Copy link
Collaborator

Please could you try passing a different adsId for each MediaItem? See the explanation here: https://exoplayer.dev/ad-insertion.html#playlists-with-ads

@giladna
Copy link

giladna commented Jun 25, 2021

From what I know changing the correlator attribute value with different timestamp each ad request solves it

samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%3Dlinear&correlator=123456

kim-vde pushed a commit that referenced this issue Jul 9, 2021
MediaItem.mediaId used to default to the content URI, but this changed:
cc26a92

Before the mediaId change linked above, a playlist of different content
all with the same ad URI would play the ads for every item. After the
change the ad would only play once (because mediaId == "" for every
item, so they're all the same). This change restores roughly the
original behaviour by always considering both mediaId and the content
URI.

#minor-release

Issue: #9106
PiperOrigin-RevId: 382763618
icbaker added a commit that referenced this issue Jul 21, 2021
MediaItem.mediaId used to default to the content URI, but this changed:
cc26a92

Before the mediaId change linked above, a playlist of different content
all with the same ad URI would play the ads for every item. After the
change the ad would only play once (because mediaId == "" for every
item, so they're all the same). This change restores roughly the
original behaviour by always considering both mediaId and the content
URI.

Issue: #9106
PiperOrigin-RevId: 382763618
@google google locked and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants