Replace Hash(Map|Set) with LinkedHash(Map|Set) in several passes

It is preferable to consistently use the Linked* version of these classes,
because that will force a deterministic iteration order for them
(order of insertion), instead of a non-deterministic order, which could
lead to non-deterministic compiler output.

PiperOrigin-RevId: 543464824

src/com/google/javascript/jscomp/Es6RenameVariablesInParamLists.java

@@ -22,7 +22,7 @@
 import com.google.javascript.jscomp.parsing.parser.FeatureSet;
 import com.google.javascript.jscomp.parsing.parser.FeatureSet.Feature;
 import com.google.javascript.rhino.Node;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;
 
@@ -94,7 +94,7 @@ public void process(Node externs, Node root) {
   /** Collects all references in a naive way. */
   private static class CollectReferences {
 
-    private final Set<String> currFuncReferences = new HashSet<>();
+    private final Set<String> currFuncReferences = new LinkedHashSet<>();
 
     void collect(Node fn) {
       checkState(fn.isFunction());

src/com/google/javascript/jscomp/Es6RewriteBlockScopedDeclaration.java

@@ -34,7 +34,6 @@
 import com.google.javascript.rhino.JSDocInfo;
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.Token;
-import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
 import java.util.Map;
@@ -56,9 +55,9 @@ public final class Es6RewriteBlockScopedDeclaration extends AbstractPostOrderCal
   private final AbstractCompiler compiler;
   private final AstFactory astFactory;
   private final Table<Node, String, String> renameTable = HashBasedTable.create();
-  private final Set<Node> letConsts = new HashSet<>();
-  private final Set<String> undeclaredNames = new HashSet<>();
-  private final Set<String> externNames = new HashSet<>();
+  private final Set<Node> letConsts = new LinkedHashSet<>();
+  private final Set<String> undeclaredNames = new LinkedHashSet<>();
+  private final Set<String> externNames = new LinkedHashSet<>();
   private static final FeatureSet transpiledFeatures =
       FeatureSet.BARE_MINIMUM.with(Feature.LET_DECLARATIONS, Feature.CONST_DECLARATIONS);
   private final Supplier<String> uniqueNameIdSupplier;

src/com/google/javascript/jscomp/Es6RewriteGenerators.java

@@ -37,6 +37,8 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
+import java.util.LinkedHashMap;
+import java.util.LinkedHashSet;
 import org.jspecify.nullness.Nullable;
 
 /**
@@ -1122,13 +1124,13 @@ private boolean isEndOfBlockUnreachable(Node block) {
 
     /** State machine context that is used during generator function transpilation. */
     private class TranspilationContext {
-      final HashMap<String, LabelCases> namedLabels = new HashMap<>();
+      final HashMap<String, LabelCases> namedLabels = new LinkedHashMap<>();
       final ArrayDeque<Case> breakCases = new ArrayDeque<>();
       final ArrayDeque<Case> continueCases = new ArrayDeque<>();
 
       final ArrayDeque<CatchCase> catchCases = new ArrayDeque<>();
       final ArrayDeque<Case> finallyCases = new ArrayDeque<>();
-      final HashSet<String> catchNames = new HashSet<>();
+      final HashSet<String> catchNames = new LinkedHashSet<>();
 
       /** All "case" sections that will be added to generator program. */
       final ArrayList<Case> allCases = new ArrayList<>();

src/com/google/javascript/jscomp/ParenthesizeFunctionsInChunks.java

@@ -27,7 +27,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Deque;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -86,7 +86,7 @@ private static class Traversal implements NodeTraversal.Callback {
     private final ListMultimap<Node, Node> hoistNodesToScope = ArrayListMultimap.create();
 
     // Map for recording diagnostic information about what was marked for eager compilation.
-    private final Map<String, Long> chunkToEagerCompileFnCounts = new HashMap<>();
+    private final Map<String, Long> chunkToEagerCompileFnCounts = new LinkedHashMap<>();
 
     public Traversal(Set<String> parenthesizeFunctionsInChunks) {
       this.parenthesizeFunctionsInChunks = parenthesizeFunctionsInChunks;

src/com/google/javascript/jscomp/VariableReferenceCheck.java

@@ -25,7 +25,7 @@
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.QualifiedName;
 import com.google.javascript.rhino.Token;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Set;
 import org.jspecify.nullness.Nullable;
@@ -79,7 +79,7 @@ class VariableReferenceCheck implements CompilerPass {
 
   // NOTE(nicksantos): It's a lot faster to use a shared Set that
   // we clear after each method call, because the Set never gets too big.
-  private final Set<BasicBlock> blocksWithDeclarations = new HashSet<>();
+  private final Set<BasicBlock> blocksWithDeclarations = new LinkedHashSet<>();
 
   // These types do not permit a block-scoped declaration inside them without an explicit block.
   // e.g. if (b) let x;
@@ -112,7 +112,7 @@ private class ReferenceCheckingBehavior implements Behavior {
     private final Set<String> varsInFunctionBody;
 
     private ReferenceCheckingBehavior() {
-      varsInFunctionBody = new HashSet<>();
+      varsInFunctionBody = new LinkedHashSet<>();
     }
 
     @Override