gradle: add max-page-size 16384 #1213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses Gradle 7, so must specify page size exactly, rather
than being able to use the newer options.
This may not update the APK alignment, but you can always run
zipalign to realign an unaligned APK. Or, if you pull the .so
directly it will work.
prbprbprb
requested changes
Aug 16, 2024
android/build.gradle
Outdated
| @@ -60,6 +60,7 @@ if (androidSdkInstalled) { | |||
| "-DBORINGSSL_HOME=$boringsslHome", | |||
| "-DCMAKE_CXX_STANDARD=17" | |||
| cFlags '-fvisibility=hidden', | |||
| '-Wl,-z,max-page-size=16384', | |||
There was a problem hiding this comment.
I'd suggest putting linker flags at the end of the list.
There was a problem hiding this comment.
Actually turns out this isn't the way to do it with external cmake, only actual cflags can do in here.
You want to add '-DCMAKE_SHARED_LINKER_FLAGS=-z max-page-size=16384' to the cmake arguments.
There was a problem hiding this comment.
Done, and thank you thank you, I had to do something slightly differently, but I think this should work now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Gradle 7, so must specify page size exactly, rather than being able to use the newer options.
This may not update the APK alignment, but you can always run zipalign to realign an unaligned APK. Or, if you pull the .so directly it will work.