blob: use new URLMux pattern for OpenBucket #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design discussion in google#1209. Updates google#1174
vangent
requested changes
Feb 11, 2019
|
|
||
| if region := q["region"]; len(region) > 0 { |
There was a problem hiding this comment.
Can you put these back into the default implementation?
There was a problem hiding this comment.
Can you help me understand why they're here? They seem to only be for constructing the session and aren't specific to the S3 bucket. I removed them because it seemed like based on our new design principles that someone who wants to override these would create a new s3blob.URLOpener.
There was a problem hiding this comment.
I failed to follow up on this comment. I think it's important to include these, will send a PR.
|
Can you sync to HEAD as well? Looks like there are some conflicts, hopefully not too hairy. |
Address some documentation concerns in the process
|
PTAL |
This was referenced Feb 12, 2019
vangent
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design discussion in #1209.
A follow-up PR will shorten the tutorial to use
blob.OpenBucket.Updates #1174