Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtimevar: add infrastructure for opening Variables via URL #1413

Merged
merged 2 commits into from
Feb 28, 2019
Merged

runtimevar: add infrastructure for opening Variables via URL #1413

merged 2 commits into from
Feb 28, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Feb 27, 2019

Updates #1174.

I plan on adding per-driver openers in a separate PR.

@googlebot googlebot added the cla: yes Google CLA has been signed! label Feb 27, 2019
@vangent
Copy link
Contributor Author

vangent commented Feb 27, 2019

Note: this code is largely copied from blob.go, just repeating the pattern.

zombiezen
zombiezen approved these changes Feb 28, 2019
View reviewed changes
blob/blob.go Show resolved Hide resolved
@vangent vangent merged commit 2ffaa29 into google:master Feb 28, 2019
@vangent vangent deleted the rtv-url branch February 28, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombiezen zombiezen zombiezen approved these changes

Assignees

@zombiezen zombiezen

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vangent @zombiezen @googlebot