Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets: add support for URLOpeners to all drivers #1427

Merged
merged 7 commits into from
Mar 5, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Mar 1, 2019

This is mostly mechanical, copying the pattern @zombiezen established for blob.

The interesting parts are probably:

  • I made localsecrets register for 2 schemes, 'stringkey://" and "base64key://".
  • vault is a bit interesting since the URL contains the Vault server address + token; I made it Dial but cache the result.

Updates #1174.

@vangent vangent requested review from clausti and shantuo March 1, 2019 17:40
@googlebot googlebot added the cla: yes Google CLA has been signed! label Mar 1, 2019
internal/testing/setup/setup.go Outdated Show resolved Hide resolved
secrets/awskms/kms.go Outdated Show resolved Hide resolved
secrets/localsecrets/localsecrets.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #1427 into master will increase coverage by 0.28%.
The diff coverage is 82.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage    76.9%   77.19%   +0.28%     
==========================================
  Files          58       58              
  Lines        4517     4621     +104     
==========================================
+ Hits         3474     3567      +93     
- Misses        872      875       +3     
- Partials      171      179       +8
Impacted Files Coverage Δ
secrets/localsecrets/localsecrets.go 95.23% <100%> (+3.93%) ⬆️
secrets/gcpkms/kms.go 74.13% <60%> (-7.45%) ⬇️
secrets/awskms/kms.go 80% <75%> (-5.37%) ⬇️
secrets/vault/vault.go 92.59% <90.9%> (-2.15%) ⬇️
blob/fileblob/fileblob.go 80.28% <0%> (+0.56%) ⬆️
pubsub/mempubsub/mem.go 85.55% <0%> (+2.22%) ⬆️
secrets/secrets.go 92.3% <0%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257978f...bdf92a2. Read the comment docs.

@vangent
Copy link
Contributor Author

vangent commented Mar 4, 2019

Gentle ping @clausti ?

@vangent vangent merged commit 74ebfc5 into google:master Mar 5, 2019
@vangent vangent deleted the url-secrets branch March 5, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants