Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtimevar: add URLOpeners for etcdvar, filevar, paramstore, and runtimeconfigurator #1463

Merged
merged 9 commits into from
Mar 7, 2019
Merged

runtimevar: add URLOpeners for etcdvar, filevar, paramstore, and runtimeconfigurator #1463

merged 9 commits into from
Mar 7, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Mar 5, 2019

Updates #1174.

@vangent vangent requested a review from shantuo March 5, 2019 20:04
@googlebot googlebot added the cla: yes Google CLA has been signed! label Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #1463 into master will increase coverage by 0.24%.
The diff coverage is 86.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
+ Coverage   77.19%   77.43%   +0.24%     
==========================================
  Files          64       64              
  Lines        5473     5611     +138     
==========================================
+ Hits         4225     4345     +120     
- Misses       1010     1020      +10     
- Partials      238      246       +8
Impacted Files Coverage Δ
runtimevar/runtimevar.go 96.84% <100%> (+5.07%) ⬆️
secrets/azurekeyvault/akv.go 72% <100%> (-1.08%) ⬇️
...timevar/runtimeconfigurator/runtimeconfigurator.go 83.87% <80%> (-1.85%) ⬇️
runtimevar/paramstore/paramstore.go 87.28% <85.29%> (-0.81%) ⬇️
runtimevar/filevar/filevar.go 85.59% <87.5%> (+0.48%) ⬆️
runtimevar/etcdvar/etcdvar.go 92.18% <88.23%> (-1.43%) ⬇️
pubsub/mempubsub/mem.go 83.33% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b164fb...8131056. Read the comment docs.

shantuo
shantuo requested changes Mar 6, 2019
View reviewed changes
runtimevar/etcdvar/etcdvar.go Show resolved Hide resolved
runtimevar/etcdvar/etcdvar_test.go Outdated Show resolved Hide resolved
runtimevar/etcdvar/example_test.go Outdated Show resolved Hide resolved
runtimevar/filevar/example_test.go Outdated Show resolved Hide resolved
runtimevar/paramstore/example_test.go Outdated Show resolved Hide resolved
runtimevar/filevar/filevar_test.go Show resolved Hide resolved
runtimevar/paramstore/paramstore.go Outdated Show resolved Hide resolved
runtimevar/paramstore/paramstore.go Show resolved Hide resolved
runtimevar/runtimeconfigurator/example_test.go Outdated Show resolved Hide resolved
runtimevar/runtimeconfigurator/runtimeconfigurator.go Outdated Show resolved Hide resolved
@vangent
Copy link
Contributor Author

vangent commented Mar 6, 2019

PTAL

@vangent vangent merged commit bf08e72 into google:master Mar 7, 2019
@vangent vangent deleted the url-rtv2 branch March 7, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantuo shantuo shantuo approved these changes

Assignees

@shantuo shantuo

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vangent @shantuo @googlebot