Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire: make Vendor test work with Go module #469

Merged
merged 2 commits into from
Sep 21, 2018
Merged

wire: make Vendor test work with Go module #469

merged 2 commits into from
Sep 21, 2018

Conversation

shantuo
Copy link
Contributor

@shantuo shantuo commented Sep 19, 2018

  1. vendor directory is used only at the top level with Go module turned on and "-mod=vendor" is used.
  2. The dummy bar package needs to be removed or go build complains ambiguity.

Fixes #326

@shantuo shantuo requested a review from ijt September 19, 2018 22:19
@googlebot googlebot added the cla: yes Google CLA has been signed! label Sep 19, 2018
@shantuo shantuo requested review from vangent and removed request for ijt September 21, 2018 17:21
@shantuo shantuo assigned vangent and unassigned ijt Sep 21, 2018
vangent
vangent requested changes Sep 21, 2018
View reviewed changes
wire/internal/wire/wire_test.go Outdated Show resolved Hide resolved
@vangent vangent assigned shantuo and unassigned vangent Sep 21, 2018
@vangent vangent merged commit d51dabf into google:master Sep 21, 2018
zombiezen pushed a commit to google/wire that referenced this pull request Nov 28, 2018
@shantuo @zombiezen
wire: make Vendor test work with Go module (google/go-cloud#469)
fbcb6a8
@shantuo shantuo deleted the wiretestmodulevendor branch March 22, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vangent vangent vangent approved these changes

Assignees

@shantuo shantuo

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shantuo @vangent @ijt @googlebot