Add crane auth token #1709
Merged
Add crane auth token #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 72.20% 71.74% -0.46%
==========================================
Files 121 121
Lines 9720 9782 +62
==========================================
Hits 7018 7018
- Misses 2028 2088 +60
- Partials 674 676 +2
|
jonjohnsonjr
force-pushed
the
token
branch
4 times, most recently
from
40303ce
to
4b22b71
Compare
|
This is really neat 😄 |
jonjohnsonjr
force-pushed
the
token
branch
5 times, most recently
from
657a6bc
to
53e9dda
Compare
(This makes it easier to just use curl.) In order to do this, we expose some functionality in the transport package: transport.Ping(...) Challenge transport.Exchange(..., Challenge) Token transport.FromToken(..., Challenge, Token) http.RoundTripper This will also make it possible to save a Challenge from the Ping() or a Token from the Exchange() so that callers can elide token exchanges across multiple calls (without using remote.Pusher or remote.Puller).
imjasonh
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to just use curl.
Fixes #1470