Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass scopes through crane auth token #1713

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Dropped this while refactoring. Not passing scopes can fail for some registries.

Dropped this while refactoring. Not passing scopes can fail for some
registries.
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review May 23, 2023 18:11
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #1713 (d59b05d) into main (53fbcf9) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   72.04%   72.02%   -0.02%     
==========================================
  Files         121      121              
  Lines        9765     9766       +1     
==========================================
- Hits         7035     7034       -1     
- Misses       2056     2058       +2     
  Partials      674      674              
Impacted Files Coverage Δ
pkg/v1/remote/transport/bearer.go 69.88% <66.66%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

@jonjohnsonjr jonjohnsonjr enabled auto-merge (squash) May 23, 2023 18:12
@jonjohnsonjr jonjohnsonjr merged commit c3f8a49 into google:main May 23, 2023
@jonjohnsonjr jonjohnsonjr deleted the scopes branch May 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants