Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print pushed digest in crane push #1860

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

aw185176
Copy link
Contributor

@aw185176 aw185176 commented Jan 8, 2024

Currently if you use --image-refs with crane push, the result reference doesn't get pushed if the manifest already exists, e.g.:

2024/01/03 21:50:41 existing manifest: sha256:eef3b150e5e8d2b5b9ff7ed861ba503e0093139f595f9a549f614b64b6d6e1b2
2024/01/03 21:50:45 existing manifest: dev@sha256:eef3b150e5e8d2b5b9ff7ed861ba503e0093139f595f9a549f614b64b6d6e1b2

This change ensures that crane push always prints the full reference that was pushed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55ffb00) 71.65% compared to head (f20a366) 71.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1860   +/-   ##
=======================================
  Coverage   71.65%   71.65%           
=======================================
  Files         123      123           
  Lines        9928     9928           
=======================================
  Hits         7114     7114           
  Misses       2115     2115           
  Partials      699      699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonjohnsonjr jonjohnsonjr merged commit a0658aa into google:main Jan 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants