Actually call default methods in AssistedInject factories #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks for this PR. We unfortunately can't merge it, though, because we have no way of knowing if the factory author wants Guice to override the default methods. Merging would break folks who are relying on the current behavior. We could consider an additional annotation (like @IgnoreThisForAssistedInjection), but that's pretty darn heavyweight and not very ergonomic. Ultimately, the best solution is for folks to create a separate factory with just the methods they'd like Guice to fit to assisted injection. |
|
I recently ran into this issue too - some sort of way (even if not the prettiest - an annotation like @sameb mentioned is not the worst) to support this would be great. |
jpenilla
added a commit
to jpenilla/guice
that referenced
this pull request
Aug 4, 2023
…thods on assisted factories (but only when explicitly requested by the user, see google#1347 (comment))
jpenilla
added a commit
to jpenilla/guice
that referenced
this pull request
Aug 5, 2023
…thods on assisted factories (but only when explicitly requested by the user, see google#1347 (comment))
jpenilla
added a commit
to jpenilla/guice
that referenced
this pull request
Aug 5, 2023
…thods on assisted factories (but only when explicitly requested by the user, see google#1347 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345