Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOE Sync 2020-07-09 #1359

Merged
merged 1 commit into from
Jul 10, 2020
Merged

MOE Sync 2020-07-09 #1359

merged 1 commit into from
Jul 10, 2020

Commits on Jul 9, 2020

  1. Import #1298 

    Replace CGLIB with custom code to generate "enhancers" and "fast-classes".

Some user visible changes from using cglib:
- intercepted method that has a return type of int but returns null from the interceptor will no longer be automatically converted to 0, instead a NullPointerException will be thrown.
- Scope implementation can no longer check for circular proxy instance using CircularDependencyProxy marker class, instead should use Scopes.isCircularProxy
- Depending on which custom class loading option is used, Guice enhanced class may no longer be mockable/spyable
- Generated class name is slightly longer.

Closes #1298

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=320433559
    @mcculls
    mcculls authored and kevinb9n committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2d867c5 View commit details
    Browse the repository at this point in the history