Add a utility class for checking if Guice has enhanced a class (and returning the unenhanced version). #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_525256080
branch
from
139e697
to
8a1d7d4
Compare
|
@mcculls -- Would you be able to review this PR before I submit it? There's a couple dozen places in google's codebase where we could use it, and presumably a bunch more in the wild. Also LMK if you think this it's better to avoid adding this API at all. Thanks! (For context, I'm spending this & next week scrubbing Guice's open PRs & issues as a tribute to @crazybob.) |
mcculls
reviewed
Apr 22, 2023
|
|
||
| /** Returns true if this is a class that Guice enhanced with AOP functionality. */ | ||
| public static boolean isEnhanced(Class<?> clazz) { | ||
| return ENHANCED.matcher(clazz.getSimpleName()).matches(); |
There was a problem hiding this comment.
If you wanted to simplify this then just checking the simple name contained the BytecodeGen.ENHANCER_BY_GUICE_MARKER string would IMHO be enough.
mcculls
reviewed
Apr 22, 2023
| if (!isEnhanced(clazz)) { | ||
| return Optional.empty(); | ||
| } | ||
| return Optional.of(clazz.getSuperclass()); |
There was a problem hiding this comment.
I find the ternary style easier to read, but that's just a matter of taste :)
return isEnhanced(clazz) ? Optional.of(clazz.getSuperclass()) : Optional.empty();
|
Thanks for reviewing! |
copybara-service
bot
force-pushed
the
test_525256080
branch
from
8a1d7d4
to
342b07e
Compare
copybara-service
bot
force-pushed
the
test_525256080
branch
from
342b07e
to
4baf691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a utility class for checking if Guice has enhanced a class (and returning the unenhanced version).
(Also changes the classname suffix to be a hex string instead of an int, which had previously included a leading negative sign, which was weird.)
Fixes #1340 & fixes #187.