Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and and or in Matcher directly #1716

Closed
wants to merge 1 commit into from

Conversation

kashike
Copy link
Contributor

@kashike kashike commented Apr 29, 2023

#1177

This makes AbstractMatcher itself empty now - do you want it to be marked as deprecated?

@sameb
Copy link
Member

sameb commented Apr 29, 2023

I'm a little concerned that removing the overrides from AbstractMatcher will break binary compatibility with old jars that delegate to AbstractMatcher.{and,or}. WDYT of keeping those overrides (even though they're redundant on the source-code level)?

Marking as @deprecated SGTM, with the javadoc explaining how implementing Matcher is enough (because of the default and and or methods).

@kashike
Copy link
Contributor Author

kashike commented Apr 29, 2023

@sameb Sounds good - changes made. Let me know if that looks good now.

@copybara-service copybara-service bot closed this in a99b87a May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants