Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of bindings in ProvisionListenerCallbackStore and simplify #1787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Contributor

@HannesWell HannesWell commented Dec 30, 2023

Bindings have never been removed from the cache in ProvisionListenerCallbackStore.remove() because the key of the cache were KeyBinding objects, while it was attempted to remove Binding objects.

Additionally use a standard Java ConcurrentHashMap instead of a simple Guava Cache, which also allows to remove the now unnecessary KeyBinding helper class. Instead of a new KeyBinding object a new new lambda object is created for each cache lookup.

This also helps for #1785.

Bindings have never been removed from the cache in
ProvisionListenerCallbackStore.remove() because the key of the cache
were KeyBinding objects, while it was attempted to remove Binding
objects.

Additionally use a standard Java ConcurrentHashMap instead of a simple
Guava Cache, which also allows to remove the now unnecessary KeyBinding
helper class. Instead of a new KeyBinding object a new new lambda object
is created for each cache lookup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant