Migrate most usages of Truth8.assertThat to equivalent usages of Truth.assertThat, and qualify others.
#1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_602806147
branch
2 times, most recently
from
4927920
to
5a53750
Compare
…ruth.assertThat`, and qualify others. By "qualify," I mean that, instead of static importing `Truth8.assertThat`, we write "`Truth8.assertThat(...)`" at the call site. This is normally the opposite of what we recommend. However, it's a necessary step in our migration: We are copying all the `Truth8` methods to `Truth`, and we can't do that if any files static import both `Truth.assertThat` and `Truth8.assertThat` (because it produces a compile error about ambiguous overloads). To unblock that, we're moving callers away from the static import. We will update static analysis to stop suggesting the import. A later step will migrate these callers to the new `Truth.assertThat` methods, which we will static import. The `Truth8` methods will be hidden in the future. All callers will use `Truth`. PiperOrigin-RevId: 603073706
copybara-service
bot
force-pushed
the
test_602806147
branch
from
5a53750
to
4f94f00
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
4f94f00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate most usages of
Truth8.assertThatto equivalent usages ofTruth.assertThat, and qualify others.By "qualify," I mean that, instead of static importing
Truth8.assertThat, we write "Truth8.assertThat(...)" at the call site.This is normally the opposite of what we recommend. However, it's a necessary step in our migration: We are copying all the
Truth8methods toTruth, and we can't do that if any files static import bothTruth.assertThatandTruth8.assertThat(because it produces a compile error about ambiguous overloads). To unblock that, we're moving callers away from the static import.We will update static analysis to stop suggesting the import.
A later step will migrate these callers to the new
Truth.assertThatmethods, which we will static import.The
Truth8methods will be hidden in the future. All callers will useTruth.