avoid SVE/SVE2 on old compilers. Thanks @Xarbirus, Refs #1881 #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_626969398
branch
2 times, most recently
from
8249da8
to
7db71ec
Compare
PiperOrigin-RevId: 626986866
copybara-service
bot
force-pushed
the
test_626969398
branch
from
7db71ec
to
d4f7911
Compare
|
@jan-wassenberg I saw the issue refers to SVE2, but not SVE, is there a reason to disable both? I think this is causing the |
|
Thanks for pointing that out. I had disabled SVE as well based on gcc not being able to compile, but this was because I still had armv9- in the arch string. Looks like GCC 8 is sufficient. |
copybara-service bot
pushed a commit
that referenced
this pull request
May 7, 2024
PiperOrigin-RevId: 631341096
copybara-service bot
pushed a commit
that referenced
this pull request
May 7, 2024
PiperOrigin-RevId: 631341096
copybara-service bot
pushed a commit
that referenced
this pull request
May 7, 2024
PiperOrigin-RevId: 631341096
copybara-service bot
pushed a commit
that referenced
this pull request
May 7, 2024
PiperOrigin-RevId: 631347243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid SVE/SVE2 on old compilers. Thanks @Xarbirus, Refs #1881