Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check return value of TableBuilder::Add() in compaction routine. #1179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evanstade
Copy link
Collaborator

This is a prospective fix for the crash described in crbug.com/326566884. Inspection of the crash dump suggests that Add() is failing, but the compaction routine is continuing to run. While it's not entirely clear how precisely this leads to the observed failure mode, it seems safer to check the status of the TableBuilder and abort early as needed.

This is a prospective fix for the crash described in
crbug.com/326566884. Inspection of the crash dump suggests that
`Add()` is failing, but the compaction routine is continuing to
run. While it's not entirely clear how precisely this leads to
the observed failure mode, it seems safer to check the status
of the TableBuilder and abort early as needed.
Copy link

google-cla bot commented Apr 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant