-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split docs/rules/layers/table-c4b-layer-description.csv #225
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Piotr Katarzynski <pkatarzynski@antmicro.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we lost a bunch of newlines?
I removed the \n strings from the source CSV as they appeared as redundant "n" characters in the RTD table |
Doesn't #208 fix that? |
The script https://github.com/google/skywater-pdk/blob/master/docs/rules/periphery/periphery-split-csv.py handles periphery rules kept in a separate RST and associated CSV files. The layer rules are defined in a CSV that is explicitly included in the RST. Would it be better to make the peripherly-split-csv.py more general and re-generate the remaining rule tables from CSVs using that script? The other approach (which I followed) assumes cleaning the source CSVs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rework this so the newlines work correctly?
Cleaning up the CSV file is fine, we just should clean up the CSV file by making the newlines work correctly? |
Friendly ping! |
Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>
Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>
Tweaks the /docs/rules/layers/table-c4b-layer-description.csv table and exports the notes appended to the CSV out of the table.
Fixes #144