Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sky130_fd_pr: Fix two small issues with the spice models. #233

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Nov 10, 2020

Updating submodules on 2020-11-10 20:28:15 UTC

  • libraries/sky130_fd_pr/latest 6b9ba08...f62031a (3):

    spice: Remove .param TEMP=27.
    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.10.0 54c1ee1...6a45d86 (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.10.1 46a6658...5f8c221 (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.11.0 4596aee...c424389 (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.12.0 30e5e33...0cd300e (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.12.1 3f9ec20...be3566d (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.13.0 29fa6f3...32aede2 (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.20.0 66a8c2d...9e08415 (2):

    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

  • libraries/sky130_fd_pr/v0.20.1 6b9ba08...f62031a (3):

    spice: Remove .param TEMP=27.
    Fix usage of "temp" instead of "temper" in spice models.
    Fixing including right pm3 file from spice corner files.

Signed-off-by: Tim 'mithro' Ansell me@mith.ro

 * Fix incorrect usage of "temp" (and remove `.param TEMP=27`) which
   fixes google#171

 * Fix incorrect inclusion paths which fixes
   google#228

Updating submodules on 2020-11-10 20:28:15 UTC

 - Updating [`sky130_fd_pr` latest](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1-27-g6b9ba08..v0.20.1-44-gf62031a) to v0.20.1-44-gf62031a
 - Updating [`sky130_fd_pr` v0.10.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.0-6-g54c1ee17..v0.10.0-8-g6a45d866) to v0.10.0-8-g6a45d866
 - Updating [`sky130_fd_pr` v0.10.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.1-9-g46a66585..v0.10.1-13-g5f8c2210) to v0.10.1-13-g5f8c2210
 - Updating [`sky130_fd_pr` v0.11.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.11.0-12-g4596aee6..v0.11.0-18-gc4243899) to v0.11.0-18-gc4243899
 - Updating [`sky130_fd_pr` v0.12.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.0-15-g30e5e33e..v0.12.0-23-g0cd300ee) to v0.12.0-23-g0cd300ee
 - Updating [`sky130_fd_pr` v0.12.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.1-18-g3f9ec205..v0.12.1-28-gbe3566d2) to v0.12.1-28-gbe3566d2
 - Updating [`sky130_fd_pr` v0.13.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.13.0-21-g29fa6f30..v0.13.0-33-g32aede29) to v0.13.0-33-g32aede29
 - Updating [`sky130_fd_pr` v0.20.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.0-24-g66a8c2db..v0.20.0-38-g9e08415b) to v0.20.0-38-g9e08415b
 - Updating [`sky130_fd_pr` v0.20.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1-27-g6b9ba08..v0.20.1-44-gf62031a) to v0.20.1-44-gf62031a

 * libraries/sky130_fd_pr/latest 6b9ba08...f62031a (3):
   > spice: Remove `.param TEMP=27`.
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.10.0 54c1ee1...6a45d86 (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.10.1 46a6658...5f8c221 (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.11.0 4596aee...c424389 (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.12.0 30e5e33...0cd300e (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.12.1 3f9ec20...be3566d (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.13.0 29fa6f3...32aede2 (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.20.0 66a8c2d...9e08415 (2):
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

 * libraries/sky130_fd_pr/v0.20.1 6b9ba08...f62031a (3):
   > spice: Remove `.param TEMP=27`.
   > Fix usage of "temp" instead of "temper" in spice models.
   > Fixing including right pm3 file from spice corner files.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@StefanSchippers
Copy link

StefanSchippers commented Nov 10, 2020

checked all changes, it all looks correct to me...

Only one observation. Some changes were done on resistors by @diadatp since ngspice does not (according to his tests) support expressions for resistor temperature coefficients (tc1 and tc2). This is not an issue other than copying the values directly to the instance lines. There only is one case
(in res_xhigh_po/sky130_fd_pr__res_xhigh_po.model.spice) where tc1 is actually defined by an expression. Copying the number loses the formula dependence on parameters sky130_fd_pr__res_xhigh_po__var_mult and rsheet.
I don't know if setting tc1 = {-1.47e-3-5e-7*sky130_fd_pr__res_xhigh_po__var_mult*rsheet} on instance line works.

-rbody t1 t2 resbody r = {rbody*(1-bp2+bp2*sqrt(1+(bq2*abs(v(t1,t2))*Efac)**2))*
+rbody t1 t2 r = {rbody*(1-bp2+bp2*sqrt(1+(bq2*abs(v(t1,t2))*Efac)**2))*
 + (sub1+sub2*tanh(sub3*(min(v(r0,sub)+v(r1,sub),sub4)+sub5))) / (sub1+sub2*tanh(sub3*sub5)) }
++ tc1 = -1.47e-3
++ tc2 = 2.7e-6
+*+ tnom = 25.0
 .model resbody r tc1 = {-1.47e-3-5e-7*sky130_fd_pr__res_xhigh_po__var_mult*rsheet} tc2 = 2.7e-6 tnom = 25.0

@mithro
Copy link
Contributor Author

mithro commented Nov 11, 2020

Confirmed on the slack channel that the issues identified by @StefanSchippers shouldn't block this being merged.

@mithro mithro merged commit e9d493a into google:master Nov 11, 2020
@mithro mithro deleted the fix-171 branch November 11, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect use of "temp" instead of "temper" in sky130_fd_pr__res_iso_pw.model.spice
2 participants