-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generator for bin based plots for FETs #237
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
It seems like grouping the plots for different W values (1.0, 3.0, 5.0, 7.0) might work? You should ask on the #analog-design channel on slack about what people would find most useful |
According to the gm/Id theory you only need to do the plot for one width because you're looking for the current density, drain current/width. So you would sweep the current density for each length to get the plots. That's the theory anyway, it falls over at the extremes but for the central regions of Id/W it should hold true. |
f33e589
to
5ea58cd
Compare
@glatosinski - Please log bugs for those other issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plots don't seem to be included in the documentation anywhere?
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/fet_simulator.py
Outdated
Show resolved
Hide resolved
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/generate-docs-plots.py
Outdated
Show resolved
Hide resolved
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/generate-docs-plots.py
Outdated
Show resolved
Hide resolved
I am not sure what is the final destination for those generated files - should they end up in corresponding FET directories in |
Is this working with the rf_* fet models? When I wrote the original, it did not because these models are actually subcircuits with multiple FETs so you can't get a gm from an internal parameter and likely will have to calculate from the Vgg and Iout. Are gm values composable? (can we combine the individual gm values in the constituent fets?) |
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/fet_simulator.py
Outdated
Show resolved
Hide resolved
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/fet_simulator.py
Outdated
Show resolved
Hide resolved
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/fet_simulator.py
Outdated
Show resolved
Hide resolved
scripts/python-skywater-pdk/skywater_pdk/fet_simulator/generate-docs-plots.py
Outdated
Show resolved
Hide resolved
9e9a501
to
a5613c5
Compare
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
7ec0dca
to
0a20798
Compare
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
0a20798
to
a512ddf
Compare
Addresses #200
The scripts generate bin based plots for FETs available in the
sky130_fd_pr
library.