Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to new theme #314

Closed
wants to merge 4 commits into from
Closed

Change to new theme #314

wants to merge 4 commits into from

Conversation

daniellimws
Copy link

@daniellimws daniellimws commented Apr 16, 2021

Signed-off-by: Daniel Lim Wee Soong weesoong.lim@gmail.com

Update docs/requirements.txt to use the new SymbiFlow theme, and update conf.py to remove extra options and use the correct name for the primary and accent colors.

Also update primary color to green to improve readability. (Any comments on this?)

  • Tests pass
  • Appropriate changes to README are included in PR

Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 16, 2021
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@mithro
Copy link
Contributor

mithro commented Apr 17, 2021

We have lost a bit of functionality with this change.

  • The green colors have changed.
  • The links in the headers.
  • The expandable left hand headers.

Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws
Copy link
Author

I was trying out the darker green color as I think it is more readable, changed it back to the light green that was used before.

Also, I realized I missed out the Github and skywater links as you mentioned, and have added them already.

Currently the theme does not support expanding the headers on the left bar. I can work on adding them.

@daniellimws
Copy link
Author

Modified the theme to allow expanding of the toc links. f4pga/sphinx_f4pga_theme#8

@mithro
Copy link
Contributor

mithro commented Nov 2, 2021

@mithro mithro closed this Nov 2, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants