Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in NewUUID() #64

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Fix race in NewUUID() #64

merged 2 commits into from
Jul 2, 2020

Conversation

AstolfoKawaii
Copy link
Contributor

Fixes race in NewUUID() (non-synchronized access to nodeID)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AstolfoKawaii
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@AstolfoKawaii AstolfoKawaii changed the title Fixed race in NewUUID() Fix race in NewUUID() Jul 1, 2020
Copy link
Collaborator

@pborman pborman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. The expectation was the nodeID would only ever be set once as the standard implies it is a fixed value per machine. But you are right, there is a race condition. See my comment below about just moving some code around to get the same effect.

version1.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pborman pborman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@pborman pborman merged commit 0e4e311 into google:master Jul 2, 2020
@AstolfoKawaii AstolfoKawaii deleted the fix-race-uuid1 branch July 3, 2020 14:36
tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
* Fixed race in NewUUID()

* Remove unnecessary variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants