[project] Initial commit #292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is basically ready, except there's one outstanding safety doc comment that I can't figure out how to write. I know the safety reasoning here is pretty convoluted, so I'd love folks to double-check my work and/or suggest ways to simplify or strengthen the arguments. Referring to #196 may help in understanding the design. |
joshlf
commented
Aug 29, 2023
src/project.rs
Outdated
Comment on lines
109
to
112
| /// `Self` must be a `repr(transparent)`, `repr(packed)`, or `repr(C)` struct | ||
| /// with a single non-zero-sized field of type `Self::Inner`. `W` must be a | ||
| /// `repr(transparent)`, `repr(packed)`, or `repr(C)` struct with a single | ||
| /// non-zero field of type `F`. |
Closed
joshlf
commented
Aug 29, 2023
Comment on lines
+368
to
+384
| // TODO(#196): Is there any way to make sure this calls | ||
| // `Borrow::borrow` or `BorrowMut::borrow_mut` even if the type has | ||
| // an inherent method of the same name? |
There was a problem hiding this comment.
@kupiakos I wasn't actually able to get this to work on this PR. Did you test with this PR, or just a minimized version?
joshlf
force-pushed
the
field-project
branch
2 times, most recently
from
35847cb
to
1bd5834
Compare
Makes progress on #196
joshlf
force-pushed
the
field-project
branch
from
1bd5834
to
ca3cf29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #196