New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omit redundant yaml API extras #866

Merged

antonmedv merged 2 commits into google:main from antongolub:fix-yaml-export

Jul 4, 2024

Collaborator

antongolub commented Jun 30, 2024

Remove redundant (undocumented) YAML API extras
Override yaml pkg entry point from cjs to esm: reduce vendor bundle size by ~65Kb

Fixes #863

Tests pass
Appropriate changes to README are included in PR

antongolub added 2 commits

June 30, 2024 19:17


          fix: omit redundant yaml API extras

8812fb2


          test: update size-limit rules

7fc293e

antongolub commented

View reviewed changes

scripts/build-js.mjs

@@ @@ -64,6 +66,12 @@ const entryPoints = entry.includes('*') @@
               const _bundle = bundle !== 'none' && !process.argv.includes('--no-bundle')
               const _external = _bundle ? external.split(',') : undefined // https://github.com/evanw/esbuild/issues/1466
+              const plugins = [
+                esbuildResolvePlugin({
+                  yaml: path.resolve(__dirname, '../node_modules/yaml/browser'),

Collaborator Author

antongolub Jun 30, 2024

Workaround for eemeli/yaml#560

antonmedv merged commit d7d074d into google:main

17 checks passed

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet