Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: clean up the Transporter interface. #1407

Merged
merged 7 commits into from
Jul 10, 2023
Merged

chore!: clean up the Transporter interface. #1407

merged 7 commits into from
Jul 10, 2023

Conversation

forty
Copy link
Contributor

@forty forty commented May 5, 2022 •
edited by sofisl
Loading

Hello (again),

I took the opportunity that I was looking into it to clean up a bit the Transporter interface, as it seems to be used with Promises everywhere in the project.

Fixes #1405

@forty
chore: clean up the Transporter interface.
0273f35 
The callback signature doesn't seem to be used.
@forty forty requested review from a team as code owners May 5, 2022 17:46
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 5, 2022
@bcoe
Copy link
Contributor

bcoe commented Jul 4, 2022

@forty thanks for the contribution, we'll get this triaged soon.

@danielbankhead danielbankhead added next major: breaking change this is a change that we should wait to bundle into the next major version do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 19, 2022
danielbankhead
danielbankhead approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This looks great. Since the Transporter and BodyResponseCallback<T> interfaces are a part of the public API, this is considered breaking and will roll into the next major release.

@danielbankhead danielbankhead changed the title chore: clean up the Transporter interface. chore!: clean up the Transporter interface. Aug 19, 2022
@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 5, 2023
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 10, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@sofisl sofisl merged commit 11241e4 into googleapis:main Jul 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees

@danielbankhead danielbankhead

Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtoken request does not use the transporter
5 participants
@forty @bcoe @danielbankhead @yoshi-kokoro @sofisl