Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics (part 3) #1305

Merged
merged 2 commits into from
May 25, 2023
Merged

feat: add metrics (part 3) #1305

merged 2 commits into from
May 25, 2023

Conversation

arithmetic1728
Copy link
Contributor

This PR adds x-goog-api-client header to

  • access token and id token refresh requests, for compute engine credentials / user credentials / service account credentials / impersonated credentials
  • reauth start and continue requests
  • metadata server ping requests

Previous PRs:
Part 1: #1298
Part 2: #1303

@arithmetic1728
Copy link
Contributor Author

@aeitzman please take a look at the 3PI unit test changes. 3PI credentials use impersonated credentials, since in this PR I added x-goog-api-client header to impersonated credential's refresh method, I made the unit test changes accordingly for this new header.

@aeitzman
Copy link
Contributor

@aeitzman please take a look at the 3PI unit test changes. 3PI credentials use impersonated credentials, since in this PR I added x-goog-api-client header to impersonated credential's refresh method, I made the unit test changes accordingly for this new header.

ack - will take a look today

Copy link
Contributor

@aeitzman aeitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, everything else LGTM

tests/test_external_account.py Show resolved Hide resolved
@arithmetic1728 arithmetic1728 added the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit c7011b6 into main May 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the metric3 branch May 25, 2023 19:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants