-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kokoro #61
Add kokoro #61
Conversation
busunkim96
commented
Jan 25, 2019
- Remove Appveyor
- Remove Coveralls
- Use nox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot going on in this PR. Is it possible to split out the formatting changes from the kokoro changes?
@sduskis That sounds good, I'll separate out the PRs. |
b9ee76c
to
ad5d131
Compare
6d931a1
to
d9cf89b
Compare
d9cf89b
to
eaf3217
Compare
eaf3217
to
6b72f77
Compare
e82f0a0
to
080af20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a few changes post my changes. Turns out my encoding tests aren't going to fail under python2 since it doesn't care if the strings are bytes or not. Also changed the targets in noxfile to match our other python projects.