Skip to content

Commit

Permalink
chore: s.remove_staging_dirs() should only be called once (#57)
Browse files Browse the repository at this point in the history
There is [an issue](https://github.com/googleapis/python-workflows/blob/master/owlbot.py#L46) in the `owlbot.py` file added in #50 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over.  [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.
  • Loading branch information
parthea committed Jun 1, 2021
1 parent 0bd59d7 commit 3df424d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/google-cloud-workflows/owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
],
)

s.remove_staging_dirs()

# move workflows after executions, since we want to use "workflows" for the name
for library in s.get_staging_dirs(workflows_default_version):
if library.parent.absolute() == 'workflows':
Expand All @@ -69,4 +67,4 @@
) # the microgenerator has a good coveragerc file


s.shell.run(["nox", "-s", "blacken"], hide_output=False)
s.shell.run(["nox", "-s", "blacken"], hide_output=False)

0 comments on commit 3df424d

Please sign in to comment.