Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: 'tearDownModule' flakes with 409 #7505

Closed
tseaver opened this issue Mar 12, 2019 · 0 comments · Fixed by #8113
Closed

Storage: 'tearDownModule' flakes with 409 #7505

tseaver opened this issue Mar 12, 2019 · 0 comments · Fixed by #8113
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. flaky testing type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Mar 12, 2019

From: https://source.cloud.google.com/results/invocations/b09e6e84-ca6e-427f-8014-887b811578bc/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-python%2Fpresubmit%2Fstorage/log

    def tearDownModule():
        errors = (exceptions.Conflict, exceptions.TooManyRequests)
        retry = RetryErrors(errors, max_tries=9)
>       retry(Config.TEST_BUCKET.delete)(force=True)
...
E Conflict: 409 DELETE https://www.googleapis.com/storage/v1/b/new_1552405494808: The bucket you tried to delete was not empty.
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing type: process A process-related concern. May include testing, release, or the like. flaky labels Mar 12, 2019
@tseaver tseaver mentioned this issue Mar 12, 2019
Merged
@tseaver tseaver mentioned this issue Mar 26, 2019
Merged
@tseaver tseaver mentioned this issue May 23, 2019
Merged
tseaver added a commit that referenced this issue May 24, 2019
@tseaver
Retry harder in face of 409/429 during module teardown. (#8113)
a7932de 
Closes #7505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. flaky testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storage: retry harder in face of 409/429 during module teardown.
1 participant
@tseaver