Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use the package name in the docs url for new packages #11958

Merged
merged 1 commit into from
Nov 1, 2023
Merged

chore: use the package name in the docs url for new packages #11958

merged 1 commit into from
Nov 1, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 1, 2023

Fixes #11957

@parthea parthea requested a review from a team as a code owner November 1, 2023 15:06
@parthea parthea merged commit a99da56 into main Nov 1, 2023
17 checks passed
@parthea parthea deleted the parthea-patch-5 branch November 1, 2023 15:56
vchudnov-g
vchudnov-g reviewed Nov 1, 2023
View reviewed changes
containers/python-bootstrap-container/.repo-metadata.json
"name_pretty": "apiPrettyName",
"api_description": "",
"product_documentation": "apiProductDocumentation",
"client_documentation": "https://cloud.google.com/python/docs/reference/apiName/latest",
"client_documentation": "https://cloud.google.com/python/docs/reference/apiPackage/latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superseded by #11959 which overwrites client_documentation, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 different issues being addressed in this PR and #11959, but yes #11959 also updates this line.

#11958 addresses #11957
#11959 addresses #11193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@ohmayr ohmayr ohmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a more descriptive name in the client library documentation url for new APIs
3 participants
@parthea @vchudnov-g @ohmayr