Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding primitive Bigtable garbage collection rule classes. #1290

Merged
merged 2 commits into from
Dec 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 16, 2015

These are used as settings when creating new column
families within a table.

Also slipping in 3 small Bigtable docstring updates.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 16, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2015
.. note::

At most one of ``max_num_versions`` and ``max_age`` can be specified
at once.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2015

I am assuming (and am re-implementing under the assumption) that you are more in favor of 13+ subclasses than a class with 13+ arguments (for the filter case). (Here it's simpler since there are only two options.)

@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2015

I am assuming (and am re-implementing under the assumption) that you are more in favor of 13+ subclasses than a class with 13+ arguments (for the filter case). (Here it's simpler since there are only two options.)

Exactly, because their implementations will be super-simple / obvious. For the filters, It is also a lot clearer to map the separate classes onto a "syntax tree" when we get around to intersection / union logic.

These are used as settings when creating new column
families within a table.

Also slipping in 3 small Bigtable docstring updates.
@dhermes dhermes changed the title Adding Bigtable garbage collection rule class. Adding primitive Bigtable garbage collection rule classes. Dec 17, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

Looks like https://pypi.python.org/pypi/protobuf/3.0.0b1.post1 (released today) caused Travis to fail:

...
Collecting protobuf>=3.0.0a3
  Downloading protobuf-3.0.0b1.post1.tar.gz (200kB)

Caused by a breakage in latest protobuf release (3.0.0b1.post1).
@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

@tseaver I filed protocolbuffers/protobuf#1056 and pinned to 3.0.0a3 for now. If you like I can pin to it in another PR.

@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2015

I used _total_seconds from:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/ea4ebb7b87b9ff27ac9cae9cd7c0e5d3ad630dea/gcloud/bigquery/_helpers.py

Shouldn't we remove that version, and replace it with the new one in gcloud._helpers?

Other than that, LGTM.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

@tseaver It's not used anymore, I just remembered we had it before we put all time related stuff in gcloud._helpers.

dhermes added a commit that referenced this pull request Dec 17, 2015
Adding primitive Bigtable garbage collection rule classes.
@dhermes dhermes merged commit f143da2 into googleapis:master Dec 17, 2015
@dhermes dhermes deleted the bigtable-add-gc-rule branch December 17, 2015 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants