Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly using API_BASE_URL from current connection in datastore. #1293

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 16, 2015

This can be seen as a bug-fix where a sub-class may not be able to impact the URIs generated.

In addition, we added the (repeated) value of the base connection's API_BASE_URL in advance of swapping it out for v1beta3.

This can be seen as a bug-fix where a sub-class may not be able
to impact the URIs generated.

In addition, we added the (repeated) value of the base connection's
API_BASE_URL in advance of swapping it out for v1beta3.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 16, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2015
@dhermes dhermes mentioned this pull request Dec 16, 2015
49 tasks
@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2015

LGTM

dhermes added a commit that referenced this pull request Dec 16, 2015
Explicitly using API_BASE_URL from current connection in datastore.
@dhermes dhermes merged commit c150f8e into googleapis:master Dec 16, 2015
@dhermes dhermes deleted the datastore-local-api-base-url branch December 16, 2015 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants