Removing datastore Batch.add_auto_id_entity. #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM, modulo conflicts. |
This mutation type has been removed in v1beta3 so we just use Batch.put() to handle the previous duty. Also simplifying the helper which populates a protobuf entity from a gcloud-python Entity.
dhermes
force-pushed
the
remove-datastore-add-auto-id
branch
from
0ff93cb
to
3ec13ca
Compare
dhermes
added a commit
that referenced
this pull request
Dec 17, 2015
Removing datastore Batch.add_auto_id_entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mutation type has been removed in v1beta3 so we
just use Batch.put() to handle the previous duty.
Also simplifying the helper which populates a protobuf entity
from a gcloud-python Entity.