Adding helpers for interacting with properties in Entity protobuf. #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the repeated `property` message field in `Entity` becomes a `properties` map field in `v1beta3`. This makes adding new properties and iterating through all properties very different, so we add a helper to ease the transition from `v1beta2` to `v1beta3`.
googlebot
added
the
cla: yes
|
|
||
| :rtype: :class:`gcloud.datastore._generated.entity_pb2.Value` | ||
| :returns: The new ``Value`` protobuf that was added to the entity. | ||
| """ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 7, 2016
Adding helpers for interacting with properties in Entity protobuf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the repeated
propertymessage field inEntitybecomes apropertiesmap field inv1beta3. This makes adding new properties and iterating through all properties very different, so we add a helper to ease the transition fromv1beta2tov1beta3.