Upgrading Makefile to generate datastore v1beta3. #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@tseaver PTAL |
|
This LGTM with small nits. |
This is in advance of putting them side-by-side with datastore.
Also - Removing `v1beta2` generated code and `.proto` file - Adding new `.proto` files and generated code - Adding `make_datastore_grpc.py` script to tear out the `protoc` inserted lines by the gRPC plugin - Updating `rewrite_imports.py` to rewrite the datastore imports
Also using subprocess.call instead of check_output in the scripts that split up gRPC from non-gRPC parts of generated modules. This is because check_output swallows standard error and throws a less useful exception.
dhermes
force-pushed
the
change-over-to-v1beta3-protos-2
branch
from
62b83d5
to
dbee5b2
Compare
|
@jonparrott PTAL. |
|
LGTM. |
dhermes
added a commit
that referenced
this pull request
Feb 12, 2016
Upgrading Makefile to generate datastore v1beta3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
v1beta2generated code and.protofile.protofiles and generated codemake_datastore_grpc.pyscript to tear out theprotocinserted lines by the gRPC pluginrewrite_imports.pyto rewrite the datastore importsWas #1355 but has been re-purposed to merge against the
datastore-v1beta3branch