Merging in datastore-v1beta3 branch. #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updating the docs link in the README.
In `v1beta3` all transactions are serializable.
This is in advance of putting them side-by-side with datastore.
Also - Removing `v1beta2` generated code and `.proto` file - Adding new `.proto` files and generated code - Adding `make_datastore_grpc.py` script to tear out the `protoc` inserted lines by the gRPC plugin - Updating `rewrite_imports.py` to rewrite the datastore imports
Also using subprocess.call instead of check_output in the scripts that split up gRPC from non-gRPC parts of generated modules. This is because check_output swallows standard error and throws a less useful exception.
Updating in both the protobuf and our Query wrapper.
The sync-failure was caused by breaking up the v1beta3 changes into distinct and small changes.
This is no longer needed since the project ID is used by the datastore v1beta3 API.
This was because returned dataset IDs in v1beta2 turned foo into s~foo and sometimes this caused mismatches.
googlebot
added
the
cla: yes
|
LGTM! Just a heads up that the grpc based emulator won't be available in the cloud SDK at first. It is available for direct download. |
|
We didn't implement gRPC support yet, so that won't be an issue. Will keep it in mind when I tackle the gRPC implementation. |
|
Ok cool, I'm working to get it into the next SDK release, so it hopefully shouldn't be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288
/cc @tseaver