Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 'Table.rename'. #1908

Merged
merged 2 commits into from
Jun 26, 2016
Merged

Drop 'Table.rename'. #1908

merged 2 commits into from
Jun 26, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 26, 2016 •
edited
Loading

It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.

@tseaver
Drop 'Table.rename'.
9a2d313 
It was never actually implemented on the back-end in V1, and has been
dropped altogether in V2.
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Jun 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2016
@tseaver tseaver mentioned this pull request Jun 26, 2016
Closed
@daspecster
Copy link
Contributor

@tseaver looks like there is more to remove for this in the system-test and protos.

https://github.com/GoogleCloudPlatform/gcloud-python/search?utf8=%E2%9C%93&q=rename

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2016

@daspecster Thanks forthe catch! OK to merge now?

@daspecster
Copy link
Contributor

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2016

@daspecster

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

Yup, the _generated/ subdir is based on the Bigtable V1 protos, which contained that method, even though the backend always returned a NOT_IMPLEMENTED error. The V2 proto-generated code is added in #1903, and doesn't have the method.

Eventually (see #1384), we'd like to get rid of both those directories and rely on googleapis-generated PyPI releases for datastore and bigtable proto-generated code.

@tseaver tseaver merged commit 35103f9 into googleapis:bigtable-v2 Jun 26, 2016
@tseaver tseaver deleted the bigtable-v2-drop_table_rename branch June 26, 2016 20:33
This was referenced Jun 28, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @daspecster @dhermes @googlebot