Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguishing between unset env. var. and missing file in system test. #2087

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 11, 2016

Fixes #2084.

/cc @geigerj


Sample output

$ env | grep GCLOUD
$ env | grep GOOG
$
$ python system_tests/run_system_test.py --package datastore
D0811 08:35:27.609354178    9997 ev_posix.c:101]             Using polling engine: poll
To run the system tests, you need to set some environment variables.
Please check the CONTRIBUTING guide for instructions.

Missing variables: GCLOUD_TESTS_PROJECT_ID, GOOGLE_APPLICATION_CREDENTIALS
$
$ GOOGLE_APPLICATION_CREDENTIALS=bye GCLOUD_TESTS_PROJECT_ID=hi \
> python system_tests/run_system_test.py --package datastore
D0811 08:35:13.398294691    9979 ev_posix.c:101]             Using polling engine: poll
To run the system tests, you need to set some environment variables.
Please check the CONTRIBUTING guide for instructions.

The GOOGLE_APPLICATION_CREDENTIALS path 'bye' is not a file.
$
$ GOOGLE_APPLICATION_CREDENTIALS=bye \
> python system_tests/run_system_test.py --package datastore
D0811 08:35:19.764175549    9988 ev_posix.c:101]             Using polling engine: poll
To run the system tests, you need to set some environment variables.
Please check the CONTRIBUTING guide for instructions.

Missing variables: GCLOUD_TESTS_PROJECT_ID
The GOOGLE_APPLICATION_CREDENTIALS path 'bye' is not a file.
$
$ GOOGLE_APPLICATION_CREDENTIALS=setup.py \
> python system_tests/run_system_test.py --package datastore
D0811 08:35:37.601515289   10006 ev_posix.c:101]             Using polling engine: poll
To run the system tests, you need to set some environment variables.
Please check the CONTRIBUTING guide for instructions.

Missing variables: GCLOUD_TESTS_PROJECT_ID

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2016
@dhermes dhermes added testing and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 11, 2016
@tseaver
Copy link
Contributor

tseaver commented Aug 11, 2016

LGTM

@dhermes dhermes merged commit d71c0d4 into googleapis:master Aug 11, 2016
@dhermes dhermes deleted the fix-2084 branch August 11, 2016 19:34
@dhermes dhermes mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants