Support entity protobufs #232

tseaver · 2014-10-09T14:19:40Z

No description provided.

tseaver · 2014-10-09T14:44:11Z

Hold of merging: this PR should really deal with marshalling entity_value in Connection.save_entity and Query.filter as well.

dhermes · 2014-10-09T14:55:35Z

Should I hold off review also until the code is in place?

Handles compount fields (entity, key) not assignable via setattr.

tseaver · 2014-10-09T15:41:59Z

@dhermes Should be OK to review now.

tseaver · 2014-10-09T15:46:03Z

Hmm, with 'helpers.set_protobuf_value()' in place, I think we should deprecate (as an API) 'helpers.get_protobuf_name_and_value()': anybody using the latter is going to run into the same issues with composite values (keys, entities, later lists).

gcloud/datastore/helpers.py

@@ -103,5 +106,44 @@ def get_value_from_protobuf(pb):
    elif pb.value.HasField('string_value'):
        return pb.value.string_value

+    elif pb.value.HasField('entity_value'):
+        return Entity.from_protobuf(pb.value.entity_value)  # XXX dataset?


dhermes · 2014-10-09T18:08:59Z

RE: helpers.get_protobuf_name_and_value() I agree. Let's reduce the API surface at every chance.

@dhermes

Incorporates feedback from @dhermes.

Entities are not required to have datasets w/ active connections.

tseaver · 2014-10-09T19:54:05Z

I'm not sure anything in the 'helpers' module should be an API at all: maybe we should rename them with leading underscores to highlight that fact?

dhermes · 2014-10-09T20:06:05Z

SGTM. Since this PR touches everything in the module I don't think it's necessary to break out a new PR for the renaming.

@dhermes

Incorporates feedback from @dhermes.

Signal that they are *not* part of the gcloud-python API.

Note that these are functions, not methods.

dhermes · 2014-10-09T20:38:56Z

LGTM pending Travis.

Change that might be worth it: renaming helpers module as _helpers.

Your call either way.

Further emphasize non-API nature.

* chore(deps): update dependency google.cloud.talent to v2.5.2 * use dashes instead of dots Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

…232)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Source-Link: https://github.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

…p/templates/python_library/.kokoro (#232) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…le (#232) Source-Link: googleapis/synthtool@a7ed11e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392

Source-Link: googleapis/synthtool@dd05f9d Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:aea14a583128771ae8aefa364e1652f3c56070168ef31beb203534222d842b8b

fix(deps): require proto-plus>=1.15.0

Source-Link: googleapis/synthtool@d730883 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4370ced27a324687ede5da07132dcdc5381993502a5e8a3e31e16dc631d026f0 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: point to Search Console for domain ownership verification PiperOrigin-RevId: 521027761 Source-Link: googleapis/googleapis@e6b9d2d Source-Link: googleapis/googleapis-gen@6ae4a2c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFlNGEyY2QwNGFmYzAxMjI0MzQ2YjM5YzE5YTNjYjRlZmE0M2ZiMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@e44dc0c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d

- [ ] Regenerate this pull request now. fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-storage](https://github.com/googleapis/python-storage) | `==1.42.1` -> `==1.42.2` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.2/compatibility-slim/1.42.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.2/confidence-slim/1.42.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.42.2`](https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#1422-httpswwwgithubcomgoogleapispython-storagecomparev1421v1422-2021-09-16) [Compare Source](https://github.com/googleapis/python-storage/compare/v1.42.1...v1.42.2) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-vision).

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

) Source-Link: https://github.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…pprove] (#232) Source-Link: https://github.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

tseaver added 2 commits October 9, 2014 10:16

Add explicit support for 'entity_value' in protobufs.

1a79c89

Lint removal.

e5954fc

beriberikix added the in progress label Oct 9, 2014

tseaver mentioned this pull request Oct 9, 2014

Support 'blob_value' / 'blob_key_value' in datastore protobufs #233

Closed

tseaver added api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 9, 2014

tseaver mentioned this pull request Oct 9, 2014

Add Support for Query Cursor & Order #126

Closed

tseaver closed this Oct 9, 2014

beriberikix reopened this Oct 9, 2014

beriberikix added in progress and removed in progress labels Oct 9, 2014

tseaver added 2 commits October 9, 2014 11:30

Add helpers.set_protobuf_value.

c8f9a7a

Handles compount fields (entity, key) not assignable via setattr.

Use helpers.set_protobuf_value to support composite types.

37304c9

dhermes reviewed Oct 9, 2014
View reviewed changes

tseaver added 2 commits October 9, 2014 15:48

Fix docstring param name.

f5ee0d7

Incorporates feedback from @dhermes.

Drop XXX comment.

8fe4168

Entities are not required to have datasets w/ active connections.

tseaver added 3 commits October 9, 2014 16:28

Don't set default key on entity protobuf if entity has no key.

1679154

Incorporates feedback from @dhermes.

Rename helper functions with leading underscore.

49f04b5

Signal that they are *not* part of the gcloud-python API.

Update doctring to indicate that helper functions are not API.

275f6bd

Note that these are functions, not methods.

Rename datastore.helpers -> _helpers.

fef83a1

Further emphasize non-API nature.

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.1.2 (#232)

116389f

parthea added a commit that referenced this pull request Jun 4, 2023

fix(deps): allow protobuf 3.19.5 (#232)

3e09df6

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-securitycenter to v1.6.0 (#…

8bb96ab

…232)

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-api-python-client to v2.60.0 (#232

d9f3f1c

)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.6.0 (#232)

aff85e8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.1.2 (#232)

a026d76

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-bigquery to v2.24.0 (#232)

e446c1d

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.1.2 (#232)

c7fef3e

parthea added a commit that referenced this pull request Sep 22, 2023

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#232)

496af7f

fix(deps): require proto-plus>=1.15.0

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: use python-samples-reviewers (#232)

594c4da

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-monitoring to v2.6.0 (#232)

28a815e

parthea added a commit that referenced this pull request Oct 22, 2023

chore: update python-samples-owners as samples codeowner (#232)

721de7a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support entity protobufs #232

Support entity protobufs #232

tseaver commented Oct 9, 2014

tseaver commented Oct 9, 2014

dhermes commented Oct 9, 2014

tseaver commented Oct 9, 2014

tseaver commented Oct 9, 2014

This comment was marked as spam.

dhermes commented Oct 9, 2014

tseaver commented Oct 9, 2014

dhermes commented Oct 9, 2014

dhermes commented Oct 9, 2014

Support entity protobufs #232

Support entity protobufs #232

Conversation

tseaver commented Oct 9, 2014

tseaver commented Oct 9, 2014

dhermes commented Oct 9, 2014

tseaver commented Oct 9, 2014

tseaver commented Oct 9, 2014

This comment was marked as spam.

dhermes commented Oct 9, 2014

tseaver commented Oct 9, 2014

dhermes commented Oct 9, 2014

dhermes commented Oct 9, 2014