Moving test _helpers back into library. #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
move-test-helpers
branch
from
0c5d9f6
to
946021f
Compare
tseaver
reviewed
Sep 23, 2016
| @@ -13,17 +13,41 @@ | |||
| # limitations under the License. | |||
|
|
|||
| import os | |||
| import sys | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
FYI, the check is not successful because I canceled it to get more Travis throughput. I still waited for 5 hours on the jobs I actually wanted to run. |
This is preparation for subpackage split-up.
dhermes
force-pushed
the
move-test-helpers
branch
from
946021f
to
4b29950
Compare
|
And now I just rebased so hopefully Travis will go green soon. |
|
@tseaver PTAL |
|
LGTM |
This was referenced Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for subpackage split-up.
NOTE: Has #2393 as diffbase