Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bigtable code into a subpackage #2410

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 23, 2016

Towards #2404. See #2367 for a reference point.

Done via:

$ mkdir -p bigtable/google/cloud
$ cp google/__init__.py bigtable/google/__init__.py
$ git add bigtable/google/__init__.py
$ cp google/cloud/__init__.py bigtable/google/cloud/__init__.py
$ git add bigtable/google/cloud/__init__.py
$ git mv google/cloud/bigtable bigtable/google/cloud/bigtable
$ git mv unit_tests/bigtable bigtable/unit_tests
- Adding setup.py, MANIFEST.in, README, .coveragerc and tox.ini
- Adding google-cloud-bigtable as a dependency to the umbrella
  package
- Adding the bigtable subdirectory into the list of packages
  for verifying the docs
- Incorporating the bigtable subdirectory into the umbrella
  coverage report
- Adding the bigtable only tox tests to the Travis config
- Updating the project main README to refer the bigtable
  subdirectory
- Renamed bigtable _testing imports (since in a new place)
- Adding {toxinidir}/../core as a dependency for the bigtable
  tox config
- Updating the location of the ignored bigtable generated
  files both in the `pycodestyle` config in `tox.ini`
  and in `run_pylint`

Changed the bigtable test helper import via:

$ git grep -l 'from unit_tests.bigtable._testing import _FakeStub' |
> xargs sed -i s/'from unit_tests.bigtable._testing import _FakeStub'/'from unit_tests._testing import _FakeStub'/g
@dhermes dhermes added packaging api: bigtable Issues related to the Bigtable API. labels Sep 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 23, 2016

For reference, the 2nd commit is essentially these 3 (from core) mushed together:

@dhermes
Copy link
Contributor Author

dhermes commented Sep 23, 2016

Just occurred to me that I didn't move the system test.

@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2016

@dhermes Before merging, what did you decide to do about the system tests?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

I punted to #2404 on system tests.

@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2016

LGTM

@dhermes dhermes merged commit d1dd186 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-bigtable-subpackage branch September 26, 2016 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants