Address #233: support blob_value in protobuf #263

tseaver · 2014-10-18T01:51:39Z

The only sane way to do this is to map "text" onto 'string_value', and "bytes" onto 'blob_value'.

Since native 'str' is really "bytes" under Python2, users will need to get things decoded before setting them onto their entities if they want them to be saved as 'string_value'.

coveralls · 2014-10-18T01:59:11Z

Coverage remained the same when pulling 6f50604 on tseaver:233-support_blob_value into 86b308a on GoogleCloudPlatform:master.

dhermes · 2014-10-19T17:59:00Z

I think this will confound people but also agree this is the most sane way to go.

In a future where we have ndb-like features, the distinction will be clear.

LGTM

Addresses #233.

tseaver · 2014-10-19T21:28:06Z

Rebased to deal with merge conficts.

coveralls · 2014-10-19T21:34:56Z

Coverage remained the same when pulling d5642c9 on tseaver:233-support_blob_value into 20ac9ef on GoogleCloudPlatform:master.

tseaver · 2014-10-19T21:42:44Z

Do we need to open a new issue about documenting how people can ensure that the values they set onto entities get mapped as they expect? It is (eventually) going to have to educate folks that 'str' is "bytes" on Python2, but "text" on Python3, and mandate that they be explicit.

dhermes · 2014-10-19T22:44:39Z

Yes I like that idea. Still LGTM if you want to merge.

Address #233: support blob_value in protobuf

tseaver · 2014-10-19T23:35:43Z

#266 carries the water on the documentation issue.

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…p/templates/python_library/.kokoro (#263) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

* chore: update Go import paths to match open source chore: update gapic-generator-go version to 0.35.2 PiperOrigin-RevId: 516528222 Source-Link: googleapis/googleapis@dcd99fd Source-Link: googleapis/googleapis-gen@975f4ee Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTc1ZjRlZWE2OWE3NWI5NjVlMmYxMDNiZTFiYzgyOTcyZDRhMzVkNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: regenerate API index Source-Link: googleapis/googleapis@40a03de Source-Link: googleapis/googleapis-gen@6c17328 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmMxNzMyOGU5ZTFjMmI1OGU5NjAwNzIyZThmYzhjYmU4NDYwMGQ3ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…nction is a `GEN_1` or `GEN_2` function (#263) * feat: ListFunctions now include metadata which indicates whether a function is a `GEN_1` or `GEN_2` function PiperOrigin-RevId: 535193873 Source-Link: googleapis/googleapis@d6b7eb5 Source-Link: googleapis/googleapis-gen@822ccd0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODIyY2NkMDljYzFlOWY4YTRhYjAxMjVjYzkzZWZmZTI2YWI4ODJjMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…p/templates/python_library/.kokoro (#263) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@c5026b3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@050953d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

)

…ic enums (#263) * feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update Go import paths to match open source chore: update gapic-generator-go version to 0.35.2 PiperOrigin-RevId: 516528222 Source-Link: googleapis/googleapis@dcd99fd Source-Link: googleapis/googleapis-gen@975f4ee Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTc1ZjRlZWE2OWE3NWI5NjVlMmYxMDNiZTFiYzgyOTcyZDRhMzVkNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@38e11ad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3

* chore: use gapic-generator-python 0.63.4 chore: fix snippet region tag format chore: fix docstring code block formatting PiperOrigin-RevId: 430730865 Source-Link: googleapis/googleapis@ea58002 Source-Link: googleapis/googleapis-gen@ca893ff Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2E4OTNmZjhhZjI1ZmM3ZmUwMDFkZTE0MDVhNTE3ZDgwNDQ2ZWNjYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: delete duplicates Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

fix(deps): require proto-plus>=1.15.0

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…263) Source-Link: googleapis/synthtool@6b4d5a6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@d2871d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * revert * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@52aef91 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: googleapis/googleapis@83d81b0 Source-Link: googleapis/googleapis-gen@2ff001f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: Use gapic-generator-python 0.65.0 PiperOrigin-RevId: 440970084 Source-Link: googleapis/googleapis@5e0a3d5 Source-Link: googleapis/googleapis-gen@b0c628a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBjNjI4YTNmYWRlNzY4ZjIyNWQ3Njk5Mjc5MWVhMWJhMmE4ODFiZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

tseaver mentioned this pull request Oct 19, 2014

Finish #223: Support marshalling lists to 'value_pb.list_value' #265

Merged

tseaver added 3 commits October 19, 2014 17:27

Make '_get_protobuf_attribute_and_value' rigorous about bytes vs. text.

ad90b7b

Make '_get_value_from_value_pb' rigorous about bytes vs. text.

9809589

Add notes to docstrings about 'text' vs. 'bytes' semantics.

d5642c9

Addresses #233.

tseaver added a commit that referenced this pull request Oct 19, 2014

Merge pull request #263 from tseaver/233-support_blob_value

99e4d53

Address #233: support blob_value in protobuf

tseaver merged commit 99e4d53 into googleapis:master Oct 19, 2014

tseaver deleted the 233-support_blob_value branch October 20, 2014 20:00

tseaver mentioned this pull request Oct 20, 2014

Support 'blob_value' / 'blob_key_value' in datastore protobufs #233

Closed

dhermes mentioned this pull request Nov 3, 2014

Draw distinction between bytes in blob_value (datastore property type) and large objects in GCS #329

Closed

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-storage to v1.42.3 (#263)

c3f2fcd

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-storage to v1.42.3 (#263)

3a90bd2

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(deps): update dependency google-cloud-storage to v1.42.3 (#263)

a3da7c2

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-documentai to v1.2.1 (#263)

943ca86

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.11.1 (#263)

4344462

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-datalabeling to v1.6.1 (#263

e643dd2

)

parthea added a commit that referenced this pull request Aug 15, 2023

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#263)

f1e7a7e

fix(deps): require proto-plus>=1.15.0

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-api-python-client to v2.71.0 (#263

961baf7

)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.7.2 (#263)

89f766b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency grpcio to v1.40.0 (#263)

92d3121

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: fail samples nox session if python version is missing (#263)

9eaeed1

parthea added a commit that referenced this pull request Sep 22, 2023

docs: fix changelog header to consistent size (#263)

99ae8e9

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.10.2 (#263)

214d8c4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-translate to v3.4.1 (#263)

b154499

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#263)

0b0b5cd

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency google-cloud-storage to v1.42.3 (#263)

f7c2ac0

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency pytest to v7.1.3 (#263)

c3f1164

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address #233: support blob_value in protobuf #263

Address #233: support blob_value in protobuf #263

tseaver commented Oct 18, 2014

coveralls commented Oct 18, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

coveralls commented Oct 19, 2014

tseaver commented Oct 19, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

Address #233: support blob_value in protobuf #263

Address #233: support blob_value in protobuf #263

Conversation

tseaver commented Oct 18, 2014

coveralls commented Oct 18, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

coveralls commented Oct 19, 2014

tseaver commented Oct 19, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014