Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ACL methods chainable. #3183

Closed
wants to merge 2 commits into from

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3181

@lukesneeringer lukesneeringer self-assigned this Mar 22, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2017
@daspecster
Copy link
Contributor

@lukesneeringer I think we should have tests for this.

@daspecster
Copy link
Contributor

@lukesneeringer also note @tseaver's comment.

@lukesneeringer
Copy link
Contributor Author

Agreed on testing. Indifferent on whether we do it.

@dhermes
Copy link
Contributor

dhermes commented Mar 22, 2017

I am 👎 on method chaining. So is @tseaver and so is @jonparrott (I think)

@theacodes
Copy link
Contributor

theacodes commented Mar 22, 2017 via email

@lukesneeringer
Copy link
Contributor Author

Okay, in that case, closing this, and @daspecster please correct the errant docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants