Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix untested logging snippet examples. #3219

Merged

Conversation

daspecster
Copy link
Contributor

These snippets aren't covered in logging_snippets.py and they had a couple small syntax issues.

@daspecster daspecster added api: logging Issues related to the Cloud Logging API. docs labels Mar 28, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix untested snippet examples." doesn't keep them from being untested and breaking under future changes (or future changes in the library).

Do you have a plan to stabilize them further?

@@ -53,7 +53,7 @@ You can also exclude certain loggers:

.. code-block:: python

>>> setup_logging(handler, excluded_loggers=('werkzeug',)))
>>> setup_logging(handler, excluded_loggers=('werkzeug',))

This comment was marked as spam.

This comment was marked as spam.

@@ -117,7 +118,7 @@ def setup_logging(handler, excluded_loggers=EXCLUDED_LOGGER_DEFAULTS,

client = google.cloud.logging.Client()
handler = CloudLoggingHandler(client)
google.cloud.logging.setup_logging(handler)
google.cloud.logging.handlers.setup_logging(handler)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@lukesneeringer
Copy link
Contributor

Do you have a plan to stabilize them further?

I would love that to be a project soon, but it is not the project I gave him. :-)

@daspecster daspecster changed the title Fix untested snippet examples. Fix untested logging snippet examples. Mar 28, 2017
@lukesneeringer lukesneeringer merged commit e2921c7 into googleapis:master Mar 30, 2017
@daspecster daspecster deleted the update-logging-examples branch March 30, 2017 15:14
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants