Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming makeResource -> make_resource. #4355

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Renaming makeResource -> make_resource. #4355

merged 1 commit into from
Nov 7, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 7, 2017 •
edited
Loading

Done via:

$ git grep -l makeResource | xargs sed -i s/makeResource/make_resource/g

@dhermes
Renaming makeResource -> make_resource.
5e496f2 
Done via:

  $ git grep -l makeResource | xargs sed -i s/makeResource/make_resource/g
@dhermes dhermes added api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. hygiene labels Nov 7, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2017
@dhermes dhermes merged commit 9396bc1 into googleapis:master Nov 7, 2017
@dhermes dhermes deleted the pep8-make-resource branch November 7, 2017 22:17
@dhermes dhermes mentioned this pull request Nov 7, 2017
Merged
alixhami added a commit to alixhami/google-cloud-python that referenced this pull request Nov 10, 2017
@alixhami
updates to _make_resource() after rebasing for googleapis#4355
ea0c219
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Nov 13, 2017
@dhermes
Post googleapis#4350 cleanup.
17c721a 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@dhermes dhermes mentioned this pull request Nov 13, 2017
Merged
dhermes added a commit that referenced this pull request Nov 13, 2017
@dhermes
Post #4350 cleanup. (#4389)
db216c0 
This happened because #4350 was sent before #4355 was merged.
alixhami added a commit to alixhami/google-cloud-python that referenced this pull request Nov 15, 2017
@alixhami
updates to _make_resource() after rebasing for googleapis#4355
d5b4f12
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
9a407f5 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
1a5cfa4 
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
alixhami added a commit to alixhami/google-cloud-python that referenced this pull request Nov 22, 2017
@alixhami
updates to _make_resource() after rebasing for googleapis#4355
8184716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @lukesneeringer @googlebot