Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Security Center Client Library #6356

Merged
merged 13 commits into from
Nov 1, 2018
Merged

Generate Security Center Client Library #6356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
950ef88
synth securitycenter
crwilcox Oct 31, 2018
398fa52
changes to make docs build pass
crwilcox Oct 31, 2018
8ca68fa
synth.py changes for docs
crwilcox Nov 1, 2018
fd203a3
lower coverage percent
crwilcox Nov 1, 2018
5102a32
add kokoro configs
crwilcox Nov 1, 2018
69049ef
incorporate feedback
crwilcox Nov 1, 2018
953ce1a
add slash missing from requirements.txt
crwilcox Nov 1, 2018
f2250d5
fix links to security command center site
crwilcox Nov 1, 2018
f94686b
error in README.rst
crwilcox Nov 1, 2018
a38ab89
typo in kokoro config
crwilcox Nov 1, 2018
46bdd13
exclude docs conf.py
crwilcox Nov 1, 2018
4429241
fix linting and missing comma
crwilcox Nov 1, 2018
df2f177
add coveragerc
crwilcox Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions securitycenter/.flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[flake8]
exclude =
# Exclude generated code.
**/proto/**
**/gapic/**
*_pb2.py

# Standard linting exemptions.
__pycache__,
.git,
*.pyc,
conf.py
1 change: 1 addition & 0 deletions securitycenter/google/cloud/securitycenter_v1beta1/proto/source_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion securitycenter/google/cloud/securitycenter_v1beta1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
from google.cloud.securitycenter_v1beta1.proto import finding_pb2
from google.cloud.securitycenter_v1beta1.proto import organization_settings_pb2
from google.cloud.securitycenter_v1beta1.proto import security_marks_pb2
from google.cloud.securitycenter_v1beta1.proto import securitycenter_service_pb2
from google.cloud.securitycenter_v1beta1.proto \
import securitycenter_service_pb2

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

from google.cloud.securitycenter_v1beta1.proto import source_pb2
from google.iam.v1 import iam_policy_pb2
from google.iam.v1 import policy_pb2
Expand Down
3 changes: 2 additions & 1 deletion securitycenter/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def cover(session):
"""
session.chdir(os.path.dirname(__file__))
session.install('coverage', 'pytest-cov')
session.run('coverage', 'report', '--show-missing', '--fail-under=100')
# TODO: fail-under should be changed to 100.
crwilcox marked this conversation as resolved.
Show resolved Hide resolved
session.run('coverage', 'report', '--show-missing', '--fail-under=89')
session.run('coverage', 'erase')

2 changes: 1 addition & 1 deletion securitycenter/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
release_status = '3 - Alpha'
dependencies = [
'google-api-core[grpc] >= 1.1.0, < 2.0.0dev',
'grpc-google-iam-v1<0.12dev,>=0.11.4'
'grpc-google-iam-v1<0.12dev,>=0.11.4',
'enum34; python_version < "3.4"',
]

Expand Down